[PATCH] D18246: X86: Use push-pop for materializing 8-bit immediates for minsize (take 2)

David Kreitzer via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 13:24:44 PDT 2016

DavidKreitzer added a comment.

Please fix the >80 char line. Otherwise, LGTM.

Comment at: lib/Target/X86/X86InstrInfo.cpp:5409
@@ +5408,3 @@
+    // Can't use push/pop lowering if the function might write to the red zone.
+    X86MachineFunctionInfo *X86FI = MBB.getParent()->getInfo<X86MachineFunctionInfo>();
+    if (X86FI->getUsesRedZone()) {
It looks like this line is too long.


More information about the llvm-commits mailing list