[PATCH] D18420: [sancov] adding leading zeros to coverage pct.

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 13:22:19 PDT 2016


aizatsky added a comment.

ptal


================
Comment at: tools/sancov/sancov.cc:497
@@ +496,3 @@
+static std::string formatHtmlPct(size_t Pct) {
+  Pct = std::max(std::size_t{0}, std::min(std::size_t{100}, Pct));
+
----------------
vitalybuka wrote:
> probably std::size_t{0} ->0u  is enough
Not really. You need 0ul, but that makes this code not cross-platform.


http://reviews.llvm.org/D18420





More information about the llvm-commits mailing list