[PATCH] D18455: [ThinLTO] Use bulk importing in llvm-link

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 11:43:16 PDT 2016

joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.

See inline comments.

Comment at: tools/llvm-link/llvm-link.cpp:130
@@ +129,3 @@
+/// Helper to load on demand a Module from file and cache it for subsequent
+/// queries. It can be used with the FunctionImporter.
+class ModuleLazyLoaderCache {
` It can be used with the FunctionImporter`

The function importer is not involved here right? Comment may be updated.

Comment at: tools/llvm-link/llvm-link.cpp:259
@@ +258,3 @@
+  // Do the actual import of globals now, one Module at a time
+  for (auto &GlobalsToImportPerModule : ModuleToGlobalsToImportMap) {
+    // Get the module for the import
Do we actually want bulk import for llvm-link? Maybe doing one import at a time is a "feature", since it not testing the same thing.
It's probably good for now...


More information about the llvm-commits mailing list