[PATCH] D18281: [SetVector] Add erase() method

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 10:28:17 PDT 2016

dblaikie added inline comments.

Comment at: unittests/ADT/SetVectorTest.cpp:58
@@ +57,3 @@
+  int buf[3];
+  S.insert(&buf[0]);
+  S.insert(&buf[1]);
Might be easier to test with vectors of ints, ratehr than vectors of int*s? Then you can just use literal 0, 1, and 2 rather than the address of an array element, etc


More information about the llvm-commits mailing list