[PATCH] D18179: [mips] Correct MIPS16 jal/jalx to have uimm26 offsets and add MC layer range checks. NFC.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 08:07:49 PDT 2016

dsanders added a comment.

In http://reviews.llvm.org/D18179#379285, @vkalintiris wrote:

> LGTM. I was going to ask for few test cases, as you've done with the previous patches. However, I noticed that we don't have mips16 tests for MC.

That's right (because MIPS16 lacks any IAS support at the moment) but it's not the reason for the lack of tests. These particular instructions are marked isCodeGenOnly so tablegen doesn't generate matching code for the assembly matcher in IAS. As a result, my change has no effect but I want to avoid leaving an unchecked immediate operand for whoever adds MIPS16 support to the MC layer in the future.


More information about the llvm-commits mailing list