[PATCH] D18436: [mips] Range check simm11 and mem_simm11.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 03:36:43 PDT 2016


dsanders created this revision.
dsanders added a reviewer: vkalintiris.
dsanders added a subscriber: llvm-commits.
dsanders added a dependency: D18435: [mips] Split mem_msa into range checked mem_simm10 and mem_simm10_lsl[123].
Herald added a subscriber: dsanders.

ldc2/sdc2 now emit slightly worse diagnostics for MIPS-I. The problem
is that they don't trigger the custom parser because all the candidates
are disabled by feature bits. On all other subtargets, the diagnostics are
accurate but are subject to the usual issues of needing to report multiple
ways to correct the code (e.g. smaller offset, enable a CPU feature) but
only being able to report one error.

Depends on D18435

http://reviews.llvm.org/D18436

Files:
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/Mips/MipsInstrInfo.td
  test/MC/Mips/mips1/invalid-mips2-wrong-error.s
  test/MC/Mips/mips1/invalid-mips3-wrong-error.s
  test/MC/Mips/mips1/invalid-mips4-wrong-error.s
  test/MC/Mips/mips32r6/invalid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18436.51530.patch
Type: text/x-patch
Size: 11606 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160324/a5da897f/attachment.bin>


More information about the llvm-commits mailing list