[PATCH] D18189: [X86][XOP] Support for VPPERM byte shuffle instruction

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 13:32:37 PDT 2016

spatel added a comment.

In http://reviews.llvm.org/D18189#381652, @RKSimon wrote:

> Yes thats pretty trivial - I was really trying to avoid overloading the list with patches about instruction sets that not many people are interested in ;-) The split is very clean already:
> 1 - Add support for VPPERM:
>  X86ISelLowering.h
>  X86ISelLowering.cpp
>  X86InstrFragmentsSIMD.td
>  X86InstrXOP.td
>  X86IntrinsicsInfo.h

Can you limit this patch to only this part? I have my AMD Vol. 4 open to the vpperm page, so I can review that part first. AMD managed to redo Altivec vperm and add extra magic via the unused control bits...who knew? :)



More information about the llvm-commits mailing list