[PATCH] D18406: [sancov] code readability improvement.

[Vitaly Buka via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

LGTM anyway


================
Comment at: lib/Transforms/Instrumentation/SanitizerCoverage.cpp:319
@@ +318,3 @@
+// True if block has successors and it dominates all of them.
+static bool isFullDominator(const BasicBlock *BB, const DominatorTree *DT) {
+  if (succ_begin(BB) == succ_end(BB))
----------------
Reverse logic is still better :-)

static bool isNotFullDominator(const BasicBlock *BB, const DominatorTree *DT) {
  for (const BasicBlock *SUCC : make_range(succ_begin(BB), succ_end(BB))) {
    if (!DT->dominates(BB, SUCC))
      return true;
  }
  return false;
}

================
Comment at: lib/Transforms/Instrumentation/SanitizerCoverage.cpp:350
@@ -336,1 +349,3 @@
+
+  return !(isFullDominator(BB, DT) || isFullPostDominator(BB, PDT));
 }
----------------
return isNotFullDominator() && isNotFullPostDominator();


http://reviews.llvm.org/D18406