[PATCH] D18189: [X86][XOP] Support for VPPERM byte shuffle instruction

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 09:47:44 PDT 2016

spatel added a comment.

In http://reviews.llvm.org/D18189#379265, @RKSimon wrote:

> ping - I'm primarily interested in whether anybody has any concerns about the changes to X86MCInstLower.cpp - I realise not many people are up on the workings of XOP ;-)

I'm not a good reviewer for XOP or AVX512... :)
But can this patch be split up as:

1. Add support for VPPERM without changing getShuffleComment()
2. Enhance getShuffleComment() to support VPPERM (and VPERMT2?)



More information about the llvm-commits mailing list