[PATCH] D18049: AMDGPU i16 implementation

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 09:44:15 PDT 2016

arsenm added inline comments.

Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:270-276
@@ +269,9 @@
+    setOperationAction(ISD::SMIN, MVT::i16, Legal);
+    setOperationAction(ISD::SMAX, MVT::i16, Legal);
+    setOperationAction(ISD::UMIN, MVT::i16, Legal);
+    setOperationAction(ISD::UMAX, MVT::i16, Legal);
+    setOperationAction(ISD::SETCC, MVT::i16, Legal);
+    setOperationAction(ISD::TRUNCATE, MVT::i16, Legal);
tstellarAMD wrote:
> Same with these too.  Are they really necessary?
min/max need to be explicitly made legal, but that should be a separate patch. setcc should be promote for now until those are added later 



More information about the llvm-commits mailing list