[PATCH] D18378: Fix test failure on unrelated warnings.
Dmitry Vyukov via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 23 05:49:58 PDT 2016
dvyukov added a comment.
It can make sense to limit such changes to only the platform where we have a problem at hand (e.g. #if SANITIZER_ANDROID && defined(__aarch64__)). Especially if the platform is not working at all at the moment.
While it is generally good to make useful features available on all supported platforms, testing of such changes is tough and they have good chances of breaking things. If other platforms hit the same issue in future, maintainers can just extend the preprocessor condition (but they have a possibility to test it).
I guess should not have been LGTMed the original change with just #if defined(__aarch64__) (though, I guess all aarch64 users will hit this issue sooner or later).
More information about the llvm-commits