[PATCH] D18384: CodeGen: Correct specification of PHI nodes

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 20:40:09 PDT 2016

MatzeB added a comment.

I am posting this for review, because I did not expect the change in the AMDGPU test being necessary.

It would be nice if someone familiar with AMDGPU could double check the AMDGPU testcase change. Looking through the AMDGPU code my guess would be that SIFixSGPRLiveRanges.cpp missed PHI instruction definitions before this patch, as the phi def operands where not part of the MachineInstr::defs() iterator before this fix.

Reading the comment in that code, I'd also recommend to change the code to loop over all MachineInstr::operands(), there is nothing preventing implicit-defs to address vregs as well (though this may not happen in the AMDGPU backend today).



More information about the llvm-commits mailing list