[PATCH] D18350: Fixing DILexicalBlockFile issue in r263424

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 14:33:08 PDT 2016


aprantl added inline comments.

================
Comment at: test/DebugInfo/X86/lexical-block-file.ll:4
@@ +3,3 @@
+;; This test checks that Inlined DILexicalBlockFile with local decl entry:
+;; 1. Does not crash compilation.
+;; 2. Is Skipped and only one DW_TAG_lexical_block is generated.
----------------
Probably don't need to explicitly say this :-)

================
Comment at: test/DebugInfo/X86/lexical-block-file.ll:65
@@ +64,3 @@
+
+attributes #0 = { nounwind "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-features"="+mmx,+sse,+sse2" "unsafe-fp-math"="false" "use-soft-float"="false" }
+
----------------
Please remove all unnecessary attributes.


http://reviews.llvm.org/D18350





More information about the llvm-commits mailing list