[PATCH] D16807: [mips] MUL macro variations

Srdjan Obucina via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 14:17:26 PDT 2016


obucina marked an inline comment as done.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:3691
@@ +3690,3 @@
+    if (AssemblerOptions.back()->isReorder())
+      createNop(false, IDLoc, Instructions);
+    emitII(Mips::BREAK,6, 0, IDLoc, Instructions);
----------------
It is unclear to me what do you suggest regarding micromips potential problem with branch offset. Please be more precise.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:3722
@@ +3721,3 @@
+    emitII(Mips::BREAK, 6, 0, IDLoc, Instructions);
+  }
+
----------------
It is unclear to me what do you suggest regarding micromips potential problem with branch offset. Please be more precise.


http://reviews.llvm.org/D16807





More information about the llvm-commits mailing list