[PATCH] D18368: [SCEV] Change the SCEV Predicates interfaces for conversion to AddRecExpr to return SCEVAddRecExpr* instead of SCEV*

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 14:09:07 PDT 2016

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with minor nits

Comment at: lib/Analysis/ScalarEvolution.cpp:9916
@@ +9915,3 @@
+  S = SCEVPredicateRewriter::rewrite(S, L, *this, TransformPreds, true);
+  auto AddRec = dyn_cast<SCEVAddRecExpr>(S);
Use `auto *` here, to make it obvious that it is a pointer.

Comment at: lib/Analysis/ScalarEvolution.cpp:10141
@@ -10130,2 +10140,3 @@
   const SCEV *Expr = this->getSCEV(V);
-  const SCEV *New = SE.convertSCEVToAddRecWithPredicates(Expr, &L, Preds);
+  auto New = SE.convertSCEVToAddRecWithPredicates(Expr, &L, Preds);
Use `auto *` here (to make it obvious that this is a pointer).


More information about the llvm-commits mailing list