[PATCH] D18252: Drop comdats from the dst module if they are not selected

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 14:06:01 PDT 2016

tejohnson accepted this revision.
tejohnson added a reviewer: tejohnson.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with a couple small nits.

Comment at: lib/Linker/LinkModules.cpp:519
@@ +518,3 @@
+  // Alias have to go first, since we are no able to find their comdats
+  // otherwise.
s/no able/not able/

Comment at: test/Linker/comdat-rm-dst.ll:3
@@ +2,3 @@
+; RUN: FileCheck %s < %t
+; RUN: FileCheck --check-prefix=RM %s < %t
Why can't these two FileCheck invocations be combined? They are scanning the same output file.


More information about the llvm-commits mailing list