[PATCH] D17920: Query the StringMap only once when creating MDString (NFC)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 13:23:01 PDT 2016

dblaikie added inline comments.

Comment at: unittests/ADT/StringMapTest.cpp:366
@@ -364,2 +365,3 @@
   CountCopyAndMove() {}
+  CountCopyAndMove(unsigned int Data) : Data(Data) {}
Sign of the parameter doesn't match the sign of the member (& we usually write "unsigned int" as just "unsigned" I think?)

Comment at: unittests/ADT/StringMapTest.cpp:398
@@ -395,1 +397,3 @@
+// Test that we can "emplace" an element in the map without involving map/move
+TEST(StringMapCustomTest, EmplaceTest) {
Can we do it with a type that cannot be copied or moved? (ie: is this a static property, or a dynamic one?)


More information about the llvm-commits mailing list