[PATCH] D18350: Fixing DILexicalBlockFile issue in r263424

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 08:42:28 PDT 2016

aprantl added a comment.

Can you explain the problem that you are running into — why do you need to skip over the lexical block files (my guess is because they are not "real" lexical blocks)? The changes seem straightforward and fine to me, but a little bit of context would be helpful.

Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.h:129
@@ -128,2 +128,3 @@
   void addLocalDeclNode(const DINode *DI, DILocalScope *Scope) {
+    if (auto *File = dyn_cast<DILexicalBlockFile>(Scope))
Please add a comment here explaining why this is necessary.


More information about the llvm-commits mailing list