[PATCH] D17809: [mips] Extend MipsAsmParser class to handle expressions in the %tprel / %dtprel relocations

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 22 07:06:37 PDT 2016

dsanders added a comment.

Sorry for the delay in looking at this. I wasn't able to comment until I'd found some information on how they were expected to behave.

I see you've just abandoned the revision but it LGTM on the basis that the odd addends work the same way as GAS does.

Comment at: test/MC/Mips/tprel-hi-lo-expr.s:10
@@ +9,3 @@
+  lui     $3,%tprel_hi($loc0+0x7ffc)
+# CHECK: 0:       3c 03 7f fc     lui   $3, 32764
+# CHECK:                  00000000:  R_MIPS_TLS_TPREL_HI16    $loc0
GAS does the same thing but is this addend really correct? I'd have expected to get 'lui $3, 0' since the offset is in the low 16-bits but '$loc0+0x7ffc' seems to be interpreted as '$loc0+0x7ffc0000'



More information about the llvm-commits mailing list