[PATCH] D17625: Do not select EhPad BB in MachineBlockPlacement when there is regular BB to schedule

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 17:49:48 PDT 2016

deadalnix added inline comments.

Comment at: test/CodeGen/X86/seh-safe-div-win32.ll:68
@@ -67,3 +67,3 @@
-; CHECK: [[handler0:LBB0_[0-9]+]]: # %handler0
+; CHECK: [[handler1:LBB0_[0-9]+]]: # %handler1
 ; 	Restore SP
davidxl wrote:
> deadalnix wrote:
> > davidxl wrote:
> > > Not sure if it matters in practice. It seems that the changes in layout behavior for catch handlers as demonstrated in this test case may not be the target problem this patch intends to solve (but changed due to a side effect). In this case, it seems more natural to have handler0 laid before handler1.  Do you think this is an issue?
> > I'm not sure it changes anything in practice here as the 2 landing pads do not flow into each others. The most important part seems to me that __try.cont is scheduled before the landingpads. That being said, maybe we want a bit more tweaking for windows style EH if it turns out that this is a problem.
> The patch is probably good as it is now. Regarding this particular case, what kind of tweaking do you have in mind (just in case it is needed which I hope not)?
I'm not sure at this stage. I'd like to establish this is actually a problem worth solving before speculating on a possible solution.


More information about the llvm-commits mailing list