[PATCH] D17625: Do not select EhPad BB in MachineBlockPlacement when there is regular BB to schedule

David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 14:29:39 PDT 2016

davidxl added inline comments.

Comment at: test/CodeGen/X86/seh-safe-div-win32.ll:68
@@ -67,3 +67,3 @@
-; CHECK: [[handler0:LBB0_[0-9]+]]: # %handler0
+; CHECK: [[handler1:LBB0_[0-9]+]]: # %handler1
 ; 	Restore SP
Not sure if it matters in practice. It seems that the changes in layout behavior for catch handlers as demonstrated in this test case may not be the target problem this patch intends to solve (but changed due to a side effect). In this case, it seems more natural to have handler0 laid before handler1.  Do you think this is an issue?


More information about the llvm-commits mailing list