[PATCH] D18302: [ELF][MIPS] Delete GotSection::addMipsLocalEntry method

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 11:43:11 PDT 2016

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

I will try to find a way to handle this MIPS ABI oddity in some more readable way, but this is OK for now (and I'm not sure if such better way exists). LGTM.

By the way, I'm on vacation this week, so my response would be a bit slow this week.

Comment at: ELF/OutputSections.cpp:93
@@ -92,1 +92,3 @@
 template <class ELFT> void GotSection<ELFT>::addEntry(SymbolBody &Sym) {
+  if (Config->EMachine == EM_MIPS) {
+    if (Sym.isPreemptible())
I think we need a brief explanation what we are doing here for MIPS even if it is a duplicate with a comment in other place.



More information about the llvm-commits mailing list