[PATCH] D18320: APFloat: Fix signalling nans for scalbn

Steve Canon via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 10:03:00 PDT 2016


scanon added inline comments.

================
Comment at: lib/Support/APFloat.cpp:3987
@@ -3986,1 +3986,3 @@
   X.normalize(RoundingMode, lfExactlyZero);
+  if (X.isNaN())
+    X.makeQuiet();
----------------
Long-term, it is likely better to have `normalize` quiet SNaN.  Can you give that approach a try and see how much short-term fallout there would be?  If it's too much of a mess, we can use your current approach instead.


http://reviews.llvm.org/D18320





More information about the llvm-commits mailing list