[PATCH] D18301: [ELF] - Process R_X86_64_GOTPCRELX/R_X86_64_REX_GOTPCRELX relocations.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 08:06:15 PDT 2016

On 20 March 2016 at 06:00, George Rimar <grimar at accesssoftek.com> wrote:
> grimar created this revision.
> grimar added reviewers: ruiu, rafael.
> grimar added subscribers: llvm-commits, grimar.
> That should fix the Bug 26995 - [regression] unrecognized reloc 42 (https://llvm.org/bugs/show_bug.cgi?id=26995).
> R_X86_64_GOTPCRELX and R_X86_64_REX_GOTPCRELX relocations were added in latest ABI:
> https://github.com/hjl-tools/x86-psABI/wiki/x86-64-psABI-r249.pdf
> They should be generated instead of R_X86_64_GOTPCREL for cases when relaxation is possible.
> Currently this patch just process them in the same way like R_X86_64_GOTPCREL. That should work for now
> and we can implement relaxations later.
> Patch implementing relaxations was posted before and on review now (http://reviews.llvm.org/D15779).
> There is no testcases provided as I think there is no way to generate such relocations using llvm-mc atm.

Correct. Normally I would ask for a binary testcase, but given that we
will probably want to change llvm-mc to produce them and lld to
optimized, LGTM for now.


More information about the llvm-commits mailing list