[PATCH] D18302: [ELF][MIPS] Delete GotSection::addMipsLocalEntry method

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 07:50:12 PDT 2016

rafael added a comment.

Probably OK. Can you just fix these comments and upload a patch for another look?

Comment at: ELF/OutputSections.cpp:93
@@ -92,1 +92,3 @@
 template <class ELFT> void GotSection<ELFT>::addEntry(SymbolBody &Sym) {
+  if (Config->EMachine == EM_MIPS && (Sym.isLocal() || !Sym.isPreemptible())) {
+    // FIXME (simon): Do not add so many redundant entries.
A local symbol is not preemptable, so you can simplify the if.

Comment at: ELF/Writer.cpp:409
@@ -417,1 +408,3 @@
+        if (Body.isPreemptible())
+          Body.MustBeInDynSym = true;
Can this now be moved to addEntry? It is getting a "if mips" in this patch.



More information about the llvm-commits mailing list