[PATCH] D18144: [mips] Range check simm5.

Vasileios Kalintiris via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 21 06:54:03 PDT 2016

vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.

LGTM, one comment inline.

Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:3735-3737
@@ -3734,2 +3734,5 @@
                  "expected 5-bit unsigned immediate");
+  case Match_SImm5_0:
+    return Error(RefineErrorLoc(IDLoc, Operands, ErrorInfo),
+                 "expected 5-bit signed immediate");
   case Match_UImm5_1:
Is there any other user of this match result, ie. other than lwsp,swsp? If not then we should add a comment explaining that this case will not be hit.


More information about the llvm-commits mailing list