[PATCH] D18257: Add "first class" lowering for deopt operand bundles

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 18 18:07:44 PDT 2016


sanjoy added inline comments.

================
Comment at: test/CodeGen/X86/deopt-bundles.ll:98
@@ +97,3 @@
+; CHECK:	movl	$45, %edi
+; CHECK:	nop
+; CHECK:	popq	%rcx
----------------
reames wrote:
> Er, this doesn't look like 9 patchable bytes?  Am I missing something?
I'm only checking the prefix here, to avoid making the test case fragile around non-semantic instruction selection differences.  Should I check for a specific nop encoding here instead?


http://reviews.llvm.org/D18257





More information about the llvm-commits mailing list