[PATCH] D18258: Have DataLayout::isLegalInteger accept a uint64_t

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 18 16:24:43 PDT 2016


This revision was automatically updated to reflect the committed changes.
Closed by commit rL263850: Have DataLayout::isLegalInteger() accept uint64_t (authored by mkuper).

Changed prior to commit:
  http://reviews.llvm.org/D18258?vs=50989&id=51091#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D18258

Files:
  llvm/trunk/include/llvm/IR/DataLayout.h
  llvm/trunk/test/Transforms/SROA/pr26972.ll

Index: llvm/trunk/include/llvm/IR/DataLayout.h
===================================================================
--- llvm/trunk/include/llvm/IR/DataLayout.h
+++ llvm/trunk/include/llvm/IR/DataLayout.h
@@ -236,14 +236,14 @@
   /// on any known one. This returns false if the integer width is not legal.
   ///
   /// The width is specified in bits.
-  bool isLegalInteger(unsigned Width) const {
+  bool isLegalInteger(uint64_t Width) const {
     for (unsigned LegalIntWidth : LegalIntWidths)
       if (LegalIntWidth == Width)
         return true;
     return false;
   }
 
-  bool isIllegalInteger(unsigned Width) const { return !isLegalInteger(Width); }
+  bool isIllegalInteger(uint64_t Width) const { return !isLegalInteger(Width); }
 
   /// Returns true if the given alignment exceeds the natural stack alignment.
   bool exceedsNaturalStackAlignment(unsigned Align) const {
Index: llvm/trunk/test/Transforms/SROA/pr26972.ll
===================================================================
--- llvm/trunk/test/Transforms/SROA/pr26972.ll
+++ llvm/trunk/test/Transforms/SROA/pr26972.ll
@@ -0,0 +1,17 @@
+; RUN: opt < %s -sroa -S | FileCheck %s
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-pc-linux"
+
+; Make sure we properly handle allocas where the allocated
+; size overflows a uint32_t. This specific constant results in
+; the size in bits being 32 after truncation to a 32-bit int.
+; CHECK-LABEL: fn1
+; CHECK-NEXT: ret void
+define void @fn1() {
+  %a = alloca [1073741825 x i32], align 16
+  %t0 = bitcast [1073741825 x i32]* %a to i8*
+  call void @llvm.lifetime.end(i64 4294967300, i8* %t0)
+  ret void
+}
+
+declare void @llvm.lifetime.end(i64, i8* nocapture)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18258.51091.patch
Type: text/x-patch
Size: 1724 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160318/f5f3632f/attachment.bin>


More information about the llvm-commits mailing list