[llvm] r263825 - Revert "[sancov] specifying sanitizer coverage dependencies."

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 18 15:48:09 PDT 2016


Ack. Sorry for inconvenience.

On Fri, Mar 18, 2016 at 3:24 PM Chandler Carruth <chandlerc at google.com>
wrote:

> Hey Mike,
>
> When reverting, please use the Subversion revision number rather than the
> git commitish. It really helps when searching for a commit to see that it
> has been reverted.
>
> On Fri, Mar 18, 2016 at 9:39 PM Mike Aizatsky via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: aizatsky
>> Date: Fri Mar 18 15:34:58 2016
>> New Revision: 263825
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=263825&view=rev
>> Log:
>> Revert "[sancov] specifying sanitizer coverage dependencies."
>>
>> This fails on arm.
>>
>> This reverts commit 52c8e0f7119d1ea1050c0708565a8c92b73386d2.
>>
>> Modified:
>>     llvm/trunk/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
>>
>> Modified: llvm/trunk/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/SanitizerCoverage.cpp?rev=263825&r1=263824&r2=263825&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
>> (original)
>> +++ llvm/trunk/lib/Transforms/Instrumentation/SanitizerCoverage.cpp Fri
>> Mar 18 15:34:58 2016
>> @@ -31,7 +31,6 @@
>>  #include "llvm/ADT/ArrayRef.h"
>>  #include "llvm/ADT/SmallVector.h"
>>  #include "llvm/Analysis/EHPersonalities.h"
>> -#include "llvm/Analysis/PostDominators.h"
>>  #include "llvm/IR/CFG.h"
>>  #include "llvm/IR/CallSite.h"
>>  #include "llvm/IR/DataLayout.h"
>> @@ -161,12 +160,7 @@ class SanitizerCoverageModule : public M
>>      return "SanitizerCoverageModule";
>>    }
>>
>> -  void getAnalysisUsage(AnalysisUsage &AU) const override {
>> -    AU.addRequired<DominatorTreeWrapperPass>();
>> -    AU.addRequired<PostDominatorTreeWrapperPass>();
>> -  }
>> -
>> -private:
>> + private:
>>    void InjectCoverageForIndirectCalls(Function &F,
>>                                        ArrayRef<Instruction *>
>> IndirCalls);
>>    void InjectTraceForCmp(Function &F, ArrayRef<Instruction *>
>> CmpTraceTargets);
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160318/8149cf43/attachment.html>


More information about the llvm-commits mailing list