[llvm] r263846 - [sancov] reformat & 1 clang-tidy warning.

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 18 15:40:53 PDT 2016


Author: aizatsky
Date: Fri Mar 18 17:40:52 2016
New Revision: 263846

URL: http://llvm.org/viewvc/llvm-project?rev=263846&view=rev
Log:
[sancov] reformat & 1 clang-tidy warning.

Modified:
    llvm/trunk/tools/sancov/sancov.cc

Modified: llvm/trunk/tools/sancov/sancov.cc
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/sancov/sancov.cc?rev=263846&r1=263845&r2=263846&view=diff
==============================================================================
--- llvm/trunk/tools/sancov/sancov.cc (original)
+++ llvm/trunk/tools/sancov/sancov.cc Fri Mar 18 17:40:52 2016
@@ -83,9 +83,8 @@ static cl::list<std::string>
     ClInputFiles(cl::Positional, cl::OneOrMore,
                  cl::desc("(<binary file>|<.sancov file>)..."));
 
-static cl::opt<bool>
-    ClDemangle("demangle", cl::init(true),
-        cl::desc("Print demangled function name."));
+static cl::opt<bool> ClDemangle("demangle", cl::init(true),
+                                cl::desc("Print demangled function name."));
 
 static cl::opt<std::string> ClStripPathPrefix(
     "strip_path_prefix", cl::init(""),
@@ -518,43 +517,43 @@ static ErrorOr<bool> isCoverageFile(std:
 }
 
 class CoverageData {
- public:
+public:
   // Read single file coverage data.
-   static ErrorOr<std::unique_ptr<CoverageData>> read(std::string FileName) {
-     ErrorOr<std::unique_ptr<MemoryBuffer>> BufOrErr =
-         MemoryBuffer::getFile(FileName);
-     if (!BufOrErr)
-       return BufOrErr.getError();
-     std::unique_ptr<MemoryBuffer> Buf = std::move(BufOrErr.get());
-     if (Buf->getBufferSize() < 8) {
-       errs() << "File too small (<8): " << Buf->getBufferSize();
-       return make_error_code(errc::illegal_byte_sequence);
-     }
-     const FileHeader *Header =
-         reinterpret_cast<const FileHeader *>(Buf->getBufferStart());
-
-     if (Header->Magic != BinCoverageMagic) {
-       errs() << "Wrong magic: " << Header->Magic;
-       return make_error_code(errc::illegal_byte_sequence);
-     }
-
-     auto Addrs = llvm::make_unique<std::set<uint64_t>>();
-
-     switch (Header->Bitness) {
-     case Bitness64:
-       readInts<uint64_t>(Buf->getBufferStart() + 8, Buf->getBufferEnd(),
-                          Addrs.get());
-       break;
-     case Bitness32:
-       readInts<uint32_t>(Buf->getBufferStart() + 8, Buf->getBufferEnd(),
-                          Addrs.get());
-       break;
-     default:
-       errs() << "Unsupported bitness: " << Header->Bitness;
-       return make_error_code(errc::illegal_byte_sequence);
-     }
+  static ErrorOr<std::unique_ptr<CoverageData>> read(std::string FileName) {
+    ErrorOr<std::unique_ptr<MemoryBuffer>> BufOrErr =
+        MemoryBuffer::getFile(FileName);
+    if (!BufOrErr)
+      return BufOrErr.getError();
+    std::unique_ptr<MemoryBuffer> Buf = std::move(BufOrErr.get());
+    if (Buf->getBufferSize() < 8) {
+      errs() << "File too small (<8): " << Buf->getBufferSize();
+      return make_error_code(errc::illegal_byte_sequence);
+    }
+    const FileHeader *Header =
+        reinterpret_cast<const FileHeader *>(Buf->getBufferStart());
+
+    if (Header->Magic != BinCoverageMagic) {
+      errs() << "Wrong magic: " << Header->Magic;
+      return make_error_code(errc::illegal_byte_sequence);
+    }
+
+    auto Addrs = llvm::make_unique<std::set<uint64_t>>();
+
+    switch (Header->Bitness) {
+    case Bitness64:
+      readInts<uint64_t>(Buf->getBufferStart() + 8, Buf->getBufferEnd(),
+                         Addrs.get());
+      break;
+    case Bitness32:
+      readInts<uint32_t>(Buf->getBufferStart() + 8, Buf->getBufferEnd(),
+                         Addrs.get());
+      break;
+    default:
+      errs() << "Unsupported bitness: " << Header->Bitness;
+      return make_error_code(errc::illegal_byte_sequence);
+    }
 
-     return std::unique_ptr<CoverageData>(new CoverageData(std::move(Addrs)));
+    return std::unique_ptr<CoverageData>(new CoverageData(std::move(Addrs)));
   }
 
   // Merge multiple coverage data together.
@@ -1050,7 +1049,8 @@ public:
   }
 
   void printReport(raw_ostream &OS) const {
-    auto Title = llvm::sys::path::filename(MainObjFile) + " Coverage Report";
+    auto Title = std::string(llvm::sys::path::filename(MainObjFile) +
+                             " Coverage Report");
 
     OS << "<html>\n";
     OS << "<head>\n";




More information about the llvm-commits mailing list