[llvm] r263742 - Bitcode: Error out instead of crashing on corrupt metadata

[Rafael Espíndola via llvm-commits]

On 17 March 2016 at 15:11, David Blaikie via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Yeah, if we're going to get into the business of making bitcode robust to
> arbitrary errors, we really should talk about a testing strategy for it. I
> imagine that'll probably look like a fuzzer (as mentioned in review) and
> we'll just pull out cases from the fuzzer to check in as test cases & keep
> as part of the fuzzer's seed library (whatever the right word is for that).

I don't think a fuzzer is sufficient.

In any other area I can refactor code and have a pretty good
confidence with just check-all that I at least haven't regressed
anything.

If we don't add checks for broken files, refactoring to, for example,
use TypedError will not be as easy.

Cheers,
Rafael