[PATCH] D18164: [tsan] Do not instrument reads/writes to instruction profile counters.

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 13:18:29 PDT 2016

dvyukov added a comment.

> I am not sure what 'pretend' here means. It is possible that value '1' is still visible to other threads, or not?

Well, if we eliminate it, then it won't be visible.

If we don't eliminate it, then value 1 may or may not be visible to other threads depending on scheduler (among other things). There are no requirements for scheduler. So implementation in which value 1 is never visible to other threads is legal.


More information about the llvm-commits mailing list