[PATCH] D16201: [ELF/AArch64] - Implemented set of R_AARCH64_TLSDESC_* relocations.

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 12:15:58 PDT 2016

zatrazz added a comment.

{http://reviews.llvm.org/F1670821}I have rebased this patch against master and checked on an aarch64 machine (using both lld-test and a full bootstrap).

Comment at: ELF/OutputSections.cpp:289
@@ +288,3 @@
+  Relocs.insert(Relocs.end() - Tail, Reloc);
grimar wrote:
> Ah, Relocs is a vector, not list. That is bad line then. I`ll replace it with the list on next iteration.
I do not think this is incorrect since the vector will rearrange the itens by expanding it internally. It might however show performance regression, although I also think changing it to std::list or similar will show less performance and more memory usage (even with itens  rearrange by inserting in the middle). If you check this small performance test (http://pastie.org/10764242), std::list append shows pretty much the same performance of the std::vector rearrange (the 13000000 is number of relocation in NewLLD doc).


More information about the llvm-commits mailing list