[lld] r263664 - [ELF] SHF_MERGE section with 0 entsize is not fatal

[Sean Silva via llvm-commits]

On Wed, Mar 16, 2016 at 11:54 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> > Ok, that makes sense.
> >
> > I'm not entirely sure it's a workaround though -- I believe such files
> > are valid, if unusual. It seems in this case they may produced by an
> > lld bug; assuming that is correct and the bug gets fixed, would we
> > revert r263664?
>
> I would probably revert it, yes.
>
> There is little reason to try to figure out what a zero size entity is.
>

In the spec it says:

http://www.sco.com/developers/gabi/latest/ch4.sheader.html
sh_entsizeSome sections hold a table of fixed-size entries, such as a
symbol table. For such a section, this member gives the size in bytes of
each entry. The member contains 0 if the section does not hold a table of
fixed-size entries.

Isn't `sh_entsize == 0` what would be set for a mergeable string table? Why
haven't we run into this before?

-- Sean Silva


> Please open a bug about ld -r producing them.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160317/6be4e768/attachment.html>