[llvm] r263667 - use FileCheck for tighter checking

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 11:32:14 PDT 2016

On Thu, Mar 17, 2016 at 11:29 AM, Chandler Carruth <chandlerc at gmail.com>

> So, I really like for the -LABEL to come right after the function define
> line...
> For the x86 tests, the common pattern I settled on was to have immediately
> after the function opening, a block of -LABEL and then -NEXT to assert each
> aspect of the function, all before the label of the entry block. Any
> particular reason to deviate here?

Ah, you wanted the CHECK-LABEL to have proximity to the actual label. It
always seemed odd to me that we have the checks before the code...like
seeing the future before knowing the present. :)

The opt test case that I was initially using to debug the script was
formatted the other way around (code before checks), so I just went with
that and my anti-temporal-inversion bias. There's certainly value to having
uniformity on this, so I can switch it.

Of course, the right thing to do is just tweak the existing llc checks
script so that it can handle opt or llc (or clang) tests. I should kill my
script before it strays too far. This is the first time I've tried python,
so any changes I've made are suspect anyway!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160317/41f7141d/attachment.html>

More information about the llvm-commits mailing list