[PATCH] D18216: [Support] Creation of minidump after compiler crash on Windows

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 10:59:35 PDT 2016

aaron.ballman added a comment.

In http://reviews.llvm.org/D18216#377410, @lenykholodov wrote:

> In http://reviews.llvm.org/D18216#377216, @aaron.ballman wrote:
> > You may also want to take a look at http://reviews.llvm.org/D14022, which was implementing this same sort of idea (though it appears to have stalled a bit).
> This patch is much simpler than http://reviews.llvm.org/D14022. It was prepared as small and reliable as possible.

The point I was getting at is that we came up with a design in http://reviews.llvm.org/D14022 that we liked and there has been a fair amount of review done on already. This patch would directly conflict with that one, and so we should determine if the original author is intending to continue their work or not, and if not, what ideas from the original patch we may want to incorporate here.



More information about the llvm-commits mailing list