[PATCH] D18048: [AArch64] Enable more load clustering in the MI Scheduler.

Geoff Berry via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 09:31:38 PDT 2016

gberry added inline comments.

Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:1502
@@ +1501,3 @@
+    return false;
+  case AArch64::LDRWui:
+  case AArch64::LDURWi:
Do we always merge zext with sext loads?  I would think this would be controlled by the subtarget check we do for combining narrow loads since this combination has the same trade off with load vs arith and increased depency chain?

Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:1519
@@ -1460,3 +1518,3 @@
                                           unsigned NumLoads) const {
   // Only cluster up to a single pair.
   if (NumLoads > 1)
Shouldn't we be checking isCandidateToMergeOrPair here to avoid clustering loads that we're not going to pair?


More information about the llvm-commits mailing list