[PATCH] D18190: [ELF] - Error out when R_X86_64_PC32/R_X86_64_32 are used against preemptible symbol when linking shared object.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 17 04:25:14 PDT 2016

grimar added a comment.

In http://reviews.llvm.org/D18190#376427, @ruiu wrote:

> Ah, gotcha. So this change would break the existing test for r259831 because it would now fail because of "recompile with -fPIC" error, so you had to update it.
> But you don't have to update the binary. Remove "-shared" from llvm33-rela-outside-group.s.

So after investigation and looking on Sean's comment I think my solution was OK. My solution avoids useless stuff like add of "_start" and so on. So I agree with Sean here.
At the same time you was right when saying that I was not convinced about this test changes. Now I am.


More information about the llvm-commits mailing list