[PATCH] D18183: [ELF] - -pie/--pic-executable option implemented

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 23:05:35 PDT 2016


grimar added inline comments.

================
Comment at: test/ELF/undef.s:3-4
@@ -2,3 +2,4 @@
 # RUN: not ld.lld %t -o %t2 2>&1 | FileCheck %s
 # CHECK: undefined symbol: bar in {{.*}}
 # CHECK: undefined symbol: foo in {{.*}}
+# RUN: not ld.lld -pie %t -o %t2 2>&1 | FileCheck %s
----------------
ruiu wrote:
> Move CHECK after the following RUN. (Basically, we want to keep the source code not being "patchy". New code should look as if it were there from beginning. I don't think you wrote this way if you have written these two RUN lines)
Done. 
But I think we sometimes re-use the previously declared CHECKs when adding new RUN lines in tests. Actually If I would wrote that from beginning it would be:

```
# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t

# RUN: not ld.lld %t -o %t2 2>&1 | FileCheck %s
# CHECK: undefined symbol: bar in {{.*}}
# CHECK: undefined symbol: foo in {{.*}}

# RUN: not ld.lld -pie %t -o %t2 2>&1 | FileCheck %s
```


Repository:
  rL LLVM

http://reviews.llvm.org/D18183





More information about the llvm-commits mailing list