[PATCH] D18122: Rework linkInModule(), making it oblivious to ThinLTO

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 16:04:02 PDT 2016

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D18122#376888, @joker.eph wrote:

> Sorry missed your earlier comment...
>  We can totally remove  "NewExportedValues" as the responsibility is now
>  on the caller to specify the full list of symbols to promote.

Hmm yes, I think this is left over from when we did promotion on the exporting side via the module linker.

Thanks for the cleanup. Lgtm with a couple of nits.

Comment at: tools/llvm-link/llvm-link.cpp:200
@@ -194,2 +199,3 @@
     std::unique_ptr<ModuleSummaryIndex> Index;
     if (!SummaryIndex.empty()) {
Index declaration can be sunk inside if body now

Comment at: tools/llvm-link/llvm-link.cpp:270
@@ -262,3 +269,3 @@
     // local functions/variables as exported and promote if necessary.
     std::unique_ptr<ModuleSummaryIndex> Index;
     if (!SummaryIndex.empty()) {
This can be moved inside of if statement here too.


More information about the llvm-commits mailing list