[PATCH] D18226: Codegen: Tail-duplicate during placement.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 15:32:23 PDT 2016

echristo added a comment.

In general it looks like decent change. Could use positive testcases and it might be nice to split it apart into the "change the infrastructure to separate out the tail duplication bits" and "do additional tail dup during layout".


Comment at: lib/CodeGen/TailDuplication.cpp:848
@@ -868,2 +847,3 @@
       PredBB->addSuccessor(*I, MBPI->getEdgeProbability(TailBB, I));
+    // PredBB->updateTerminator();
No commented out code?

Comment at: test/CodeGen/AArch64/machine_cse.ll:2
@@ -2,1 +1,3 @@
+; RUN: llc < %s -mtriple=aarch64-linux-gnuabi -O2 -tail-dup-placement=0 | FileCheck %s
+; The test has a false positive when tail duplication fires during layout.
A better description?



More information about the llvm-commits mailing list