[PATCH] D18229: Upgrade TBAA *before* upgrading intrinsics
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 16 15:26:05 PDT 2016
reames added a comment.
Confusing comment needs addressed, otherwise, looks straight forward. LGTM w/comment addressed.
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5337
@@ -5336,1 +5336,3 @@
+ // Upgrading TBAA doesn't have side-effects, so we should do it first
+ for (unsigned I = 0, E = InstsWithTBAATag.size(); I < E; I++)
your comment makes this sound optional. Given this is fixing a bug, is that true?
More information about the llvm-commits