[PATCH] D18183: [ELF] - -pie/--pic-executable option implemented

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 14:01:21 PDT 2016

grimar added inline comments.

Comment at: ELF/Options.td:102
@@ -100,1 +101,3 @@
+  HelpText<"Create a position independent executable">;
 def print_gc_sections: Flag<["--"], "print-gc-sections">,
ruiu wrote:
> grimar wrote:
> > btw, not about this patch, but in general.
> > If we have errors/warnings in lowercase. Do we want HelpText here to be lowercase as well ? I guess yes.
> I don't know which is better, but this is where we just want to follow the convention. What do other command do for --help?
Hmm. clang, ld and gold has uppercase for help text. So seems no need to change anything here.


More information about the llvm-commits mailing list