[PATCH] D18200: Add __atomic_* lowering to AtomicExpandPass.

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 12:44:50 PDT 2016

reames added inline comments.

Comment at: lib/CodeGen/AtomicExpandPass.cpp:1177
@@ +1176,3 @@
+  // Build up the function call. There's two kinds. First, the sized
+  // variants.  These calls are going to be one of the following (with
If I'm reading the documentation correctly, the sized versions are purely an optimization over the generic versions correct?  The compiler is free to emit a mix of sized and generic calls on the same object?

If so, it would be nice to have the code reflect that.  In particular, it might make sense to extract a helper function which specializes generic calls with known sizes to the specialized form, and use that in way that manually written generic calls get specialized as well.  I think that would also give you an logically distinct chunk which could be factored out and submitted separately.  


More information about the llvm-commits mailing list