[LNT] r263560 - [profile] Add perf and cPerf, for importing Linux Perf profiles

Kristof Beyls via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 10:39:02 PDT 2016

On 15/03/2016 17:52, "llvm-commits on behalf of James Molloy via
llvm-commits" <llvm-commits-bounces at lists.llvm.org on behalf of
llvm-commits at lists.llvm.org> wrote:

>+//   for each mmap:
>+//       if the mmap's event total is < 1% of the total in all counters,
>+//         then discard the mmap.

Even though it's explained in the commit message, I think this comment
should explain why some samples are being discarded.

>+// The output of this module (cPerf.importPerf) is a dictionary in
>+// ProfileV1 form. The only difference is that all counters are absolute.

I don't know what ProfileV1 is. Maybe there should be a pointer to what
ProfileV1 is?

More information about the llvm-commits mailing list