[PATCH] D18190: [ELF] - Error out when R_X86_64_PC32/R_X86_64_32 are used against preemptible symbol when linking shared object.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 16 07:45:50 PDT 2016
On Wed, Mar 16, 2016 at 7:40 AM, George Rimar <grimar at accesssoftek.com>
> > This is not a fatal error which immediately let the linker terminate at
> least. So from the user's point of view, our error sometimes looks like a
> warning that just prints out a lot of > error messages (although it will
> eventually make the entire link fail at some point in future.)
> That is an issue I believe. We probably want to fatal() at some point, say
> 50 errors for example.
> (That contradicts using lld as a lib I think)
No, we don't want to turn error into fatal in this case. What I was
thinking is to dedup error messages in error() so that each error message
is displayed at most once. However, this is a different feature and we
don't need it now. So this is okay as long as other review points are
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits