[PATCH] D18190: [ELF] - Error out when R_X86_64_PC32/R_X86_64_32 are used against preemptible symbol when linking shared object.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 16 07:20:33 PDT 2016

grimar added a comment.

In http://reviews.llvm.org/D18190#376341, @ruiu wrote:

> So, if an object file has a PC32 relocation against that needs a dynamic relocation, then it also has a lot of PC32 relocation of the same kind, I guess?
> Doesn't that mean when the user see this "recompile with -pic" error message, the error message is printed out, say, 100 times when you run the linker?

Should we care ? Its wrong by nature, do you want to replace error with fatal here ?


More information about the llvm-commits mailing list