[PATCH] D18155: Instcombine: try to avoid wasted work in ConstantFold

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 17:23:41 PDT 2016

reames added a subscriber: reames.
reames requested changes to this revision.
reames added a reviewer: reames.
reames added a comment.
This revision now requires changes to proceed.

Please upload with full context; I can't review this in the current form.

In general, I'm bothered by this change.  Let me back up and ask a question, why do we need to fold the operand of the constant explicitly?  Isn't the canonical form fully folded?  (i.e. why isn't the argument already folded?)  Is there some subtlety specific to constantexprs here?



More information about the llvm-commits mailing list