[PATCH] D18167: [ELF/Driver] Avoid a reference to the ELFOptTable after it has gone out of scope

[Filipe Cabecinhas via llvm-commits]

No. Lit actually passes them on to the environment:

utils/lit/lit/TestingConfig.py:
        pass_vars = ['LIBRARY_PATH', 'LD_LIBRARY_PATH', 'SYSTEMROOT', 'TERM',
                     'LD_PRELOAD', 'ASAN_OPTIONS', 'UBSAN_OPTIONS',
                     'LSAN_OPTIONS', 'ADB', 'ANDROID_SERIAL']
        for var in pass_vars:
            val = os.environ.get(var, '')
            # Check for empty string as some variables such as
LD_PRELOAD cannot be empty
            # ('') for OS's such as OpenBSD.
            if val:
                environment[var] = val

I think we're safe.

Thank you,

  Filipe

On Tue, Mar 15, 2016 at 4:24 PM, Kostya Serebryany <kcc at google.com> wrote:
> Cool!
> please make sure that the LLVM test harness does not unset ASAN_OPTIONS
>
> On Tue, Mar 15, 2016 at 4:17 PM, Filipe Cabecinhas
> <filcab+llvm.phabricator at gmail.com> wrote:
>>
>> Hi Kostya,
>>
>> ASan-ized lld gets past check-lld without problems, so we might not
>> need any cleanup :-)
>>
>> Thank you,
>>
>>   Filipe
>>
>> On Tue, Mar 15, 2016 at 3:52 PM, Kostya Serebryany <kcc at google.com> wrote:
>> >
>> >
>> > On Mon, Mar 14, 2016 at 7:29 PM, Filipe Cabecinhas
>> > <filcab+llvm.phabricator at gmail.com> wrote:
>> >>
>> >> It looks like it should, but I can't try it out now.
>> >> I can try it tonight or tomorrow morning at most. If you want, you can
>> >> compile llvm+lld with ASan and turn on the Asan option (double-check
>> >> that
>> >> you catch the bug first ;-) ).
>> >>
>> >> CCing Kostya:
>> >> Should we add ASAN_OPTIONS=detect_stack_use_after_free=true to the
>> >> sanitizer bot?
>> >
>> >
>> > That would be lovely!
>> > Any volunteers for the cleanup?
>> >
>> >>
>> >> It would have caught this bug a long time ago.
>> >> We might also need to do some cleanup before we can do it.
>> >>
>> >> Thank you,
>> >>
>> >>   Filipe
>> >>
>> >>
>> >>
>> >> On Monday, 14 March 2016, Rui Ueyama <ruiu at google.com> wrote:
>> >>>
>> >>> ruiu added a comment.
>> >>>
>> >>> Does http://reviews.llvm.org/D18169 solves PR26908?
>> >>>
>> >>>
>> >>> http://reviews.llvm.org/D18167
>> >>>
>> >>>
>> >>>
>> >
>
>