[PATCH] D17900: [gold] Fix common symbols handling

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 16:51:56 PDT 2016

On 15 March 2016 at 13:17, Evgeniy Stepanov <eugenis at google.com> wrote:
> eugenis added a comment.
> Something weird happened here. I've accidentally committed this as r263180 instead of http://reviews.llvm.org/D17360. I need to learn arc.
> The good news is the bots are happy.
> Do you want me to revert, or could we make this a post-commit review?

No need to revert. The patch looks reasonable. It is unfortunate that
the common symbol is so convoluted, but I think that is a consequence
of the plugin api.


More information about the llvm-commits mailing list